Skip to content

Minor SMB/Kerberos improvements#4749

Merged
gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:minor-krb
May 27, 2025
Merged

Minor SMB/Kerberos improvements#4749
gpotter2 merged 1 commit into
secdev:masterfrom
gpotter2:minor-krb

Conversation

@gpotter2
Copy link
Copy Markdown
Member

@gpotter2 gpotter2 commented May 27, 2025

  • minor additions to smbclient
  • minor fixes in Kerberos client in FAST mode when handling errors

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2025

Codecov Report

Attention: Patch coverage is 22.00000% with 39 lines in your changes missing coverage. Please review.

Project coverage is 82.15%. Comparing base (8b002b6) to head (47be53d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
scapy/layers/smbclient.py 17.77% 37 Missing ⚠️
scapy/fields.py 66.66% 1 Missing ⚠️
scapy/layers/kerberos.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4749      +/-   ##
==========================================
- Coverage   82.18%   82.15%   -0.04%     
==========================================
  Files         361      361              
  Lines       87227    87276      +49     
==========================================
+ Hits        71689    71702      +13     
- Misses      15538    15574      +36     
Files with missing lines Coverage Δ
scapy/layers/smb2.py 88.11% <ø> (ø)
scapy/fields.py 92.87% <66.66%> (-0.05%) ⬇️
scapy/layers/kerberos.py 60.96% <50.00%> (+0.02%) ⬆️
scapy/layers/smbclient.py 70.95% <17.77%> (-3.01%) ⬇️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gpotter2 gpotter2 merged commit b564a13 into secdev:master May 27, 2025
24 checks passed
@gpotter2 gpotter2 deleted the minor-krb branch May 27, 2025 18:14
@gpotter2 gpotter2 added this to the 2.7.0 milestone Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant